Update gecko-dev to include some AOT ICs fixes. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in bytecodealliance/gecko-dev#52 and bytecodealliance/gecko-dev#53, fixing some issues with AOT ICs discovered after the recent rebase.
cfallin
added a commit
to cfallin/StarlingMonkey
that referenced
this pull request
Jul 27, 2024
This depends on a bunch of pending PRs: - Stacked on top of bytecodealliance#89 and bytecodealliance#90 - Pulls in spidermonkey-wasi-embedding artifacts from bytecodealliance/spidermonkey-wasi-embedding#18 (hash updated, but use local checkout variant from bytecodealliance#90 to test before that merges) When built with: ``` $ mkdir build/; cd build/ $ cmake .. -DCMAKE_BUILD_TYPE=Release -DUSE_WASM_OPT=OFF -DWEVAL=ON $ make ``` This PR will result in a `starling.wasm`, a prebuilt compilation cache of ICs in `starling-ics.wevalcache` (~1.8MiB), and a `componentize.sh` that takes a `--aot` option. I haven't yet quite worked out how to successfully use componentize.sh, so I can't claim this is end-to-end tested yet, but it is invoking weval successfully and ICs are wevaled at least.
guybedford
approved these changes
Jul 27, 2024
JakeChampion
approved these changes
Jul 27, 2024
cfallin
added a commit
to cfallin/StarlingMonkey
that referenced
this pull request
Jul 29, 2024
This depends on a bunch of pending PRs: - Stacked on top of bytecodealliance#89 and bytecodealliance#90 - Pulls in spidermonkey-wasi-embedding artifacts from bytecodealliance/spidermonkey-wasi-embedding#18 (hash updated, but use local checkout variant from bytecodealliance#90 to test before that merges) When built with: ``` $ mkdir build/; cd build/ $ cmake .. -DCMAKE_BUILD_TYPE=Release -DUSE_WASM_OPT=OFF -DWEVAL=ON $ make ``` This PR will result in a `starling.wasm`, a prebuilt compilation cache of ICs in `starling-ics.wevalcache` (~1.8MiB), and a `componentize.sh` that takes a `--aot` option. I haven't yet quite worked out how to successfully use componentize.sh, so I can't claim this is end-to-end tested yet, but it is invoking weval successfully and ICs are wevaled at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in bytecodealliance/gecko-dev#52 and
bytecodealliance/gecko-dev#53, fixing some issues with AOT ICs discovered after the recent rebase.